feat(stdlib): Add source information for slow outgoing HTTP requests #4902
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| span.finish() | ||
|
|
||
| with capture_internal_exceptions(): | ||
| add_http_request_source(span) |
There was a problem hiding this comment.
Bug: Span Data Overwriting After Completion
The add_http_request_source call is placed after span.finish() in the finally block. Adding source information to an already finished span means this data might not be properly recorded, as finished spans are generally immutable.
There was a problem hiding this comment.
I placed add_http_request_source(span) after the span is finished because you need the end timestamp to determine the delay in receiving a response to the HTTP request.
It's done analogously in asyncpg and sqlalchemy.
There was a problem hiding this comment.
Fun fact: It'd be a concern in (P)OTel as finished OTel spans can't be modified, but Sentry spans can so all good.
| span.finish() | ||
|
|
||
| with capture_internal_exceptions(): | ||
| add_http_request_source(span) |
There was a problem hiding this comment.
Fun fact: It'd be a concern in (P)OTel as finished OTel spans can't be modified, but Sentry spans can so all good.
| error_sampler=None, # type: Optional[Callable[[Event, Hint], Union[float, bool]]] | ||
| enable_db_query_source=True, # type: bool | ||
| db_query_source_threshold_ms=100, # type: int | ||
| enable_http_request_source=True, # type: bool |
There was a problem hiding this comment.
I'm generally ok with making this True by default from the get go since it's basically a copy of the existing DB query source feature, but we could also do a soft launch with the default set to False, dogfood in Sentry, and then set this to True in the next release. I'll leave it up to you.
Description
Add code source as described in getsentry/sentry-docs#15161.
Factors out functionality from SQL query source and tests that it works in the HTTP request setting.
Issues
Closes #4881
Reminders
tox -e linters.feat:,fix:,ref:,meta:)